Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve secrets from Vault, fix test-provider CI #1676

Merged
merged 20 commits into from
Apr 5, 2023
Merged

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

This PR uses Vault to pull in the necessary secrets that are needed for CI to work, specifically the test-provider workflow.
Relies on this PR to handle creating the cloud-specific service-accounts.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): update where we pull cloud secrets from

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested a review from costrouc March 10, 2023 00:23
@iameskild iameskild self-assigned this Mar 10, 2023
@iameskild iameskild mentioned this pull request Mar 14, 2023
8 tasks
@pavithraes pavithraes added the needs: review 👀 This PR is complete and ready for reviewing label Mar 21, 2023
@iameskild
Copy link
Member Author

Ignore most of these commits... I was using this branch as the base branch when testing changes to the integration tests.

@iameskild iameskild added this to the Release 2023.4.1 milestone Apr 5, 2023
@viniciusdc
Copy link
Contributor

I will re-run the tests again just to make sure they are still working, and if the test_providers passes then we are ready to merge

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant tests are passing, which leads to the conclusion that access to secrets and propagation are respected accordingly.

@iameskild iameskild merged commit ef06c1e into develop Apr 5, 2023
@iameskild iameskild deleted the fix_ci_eae branch April 5, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD 👷🏽‍♀️ needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

3 participants