-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve secrets from Vault, fix test-provider CI #1676
Conversation
Ignore most of these commits... I was using this branch as the base branch when testing changes to the integration tests. |
I will re-run the tests again just to make sure they are still working, and if the test_providers passes then we are ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant tests are passing, which leads to the conclusion that access to secrets and propagation are respected accordingly.
Reference Issues or PRs
What does this implement/fix?
This PR uses Vault to pull in the necessary secrets that are needed for CI to work, specifically the
test-provider
workflow.Relies on this PR to handle creating the cloud-specific service-accounts.
Put a
x
in the boxes that applyTesting
Any other comments?