Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upgrade command to look for nebari_version instead of qhub_version #1693

Merged
merged 7 commits into from
Apr 24, 2023

Conversation

Adam-D-Lewis
Copy link
Member

Reference Issues or PRs

What does this implement/fix?

The nebari upgrade command ran all the upgrade steps every time if your nebari-config.yaml had nebari_version since it was still expecting qhub_version. I'm fixing that here.
Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from iameskild April 4, 2023 19:50
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis :)

@kcpevey
Copy link
Contributor

kcpevey commented Apr 18, 2023

FYI - The k8s test is failing on other PRs as well. I dont know why since nothing has changed to cause that failure. Maybe its downstream dependency change?

@Adam-D-Lewis
Copy link
Member Author

@kcpevey Yeah, it certainly isn't anything in this PR. Not sure the root cause either, but I agree a dependency change seems most likely.

@Adam-D-Lewis Adam-D-Lewis merged commit 7c87a6b into develop Apr 24, 2023
@Adam-D-Lewis Adam-D-Lewis deleted the fix_upgrade_step branch April 24, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants