Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull PyPI secrets from Vault #1696

Merged
merged 4 commits into from
Apr 10, 2023
Merged

Pull PyPI secrets from Vault #1696

merged 4 commits into from
Apr 10, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Fetch PyPI secrets from Vault instead of relying on GitHub repo secrets.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costrouc costrouc merged commit 55cbc57 into develop Apr 10, 2023
@costrouc costrouc deleted the pull_pypi_secrets branch April 10, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants