Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding newest conda-store 0.4.14 along with superadmin credentials #1701

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Apr 7, 2023

This is a PR that acomplished several things:

  • updated conda-store to 0.4.14 which bring along with it several conda-store improvements: prevent out of space issues with conda-store, new ui
  • adding a new superadmin group where in conda-store superadmin group has access to all environments and can do anything
  • superadmin has access to modify keycloak user/groups/realm without the root username/password
  • admin now has access to modify users/groups without the root username/group password

Reference Issues or PRs

Closes #1177
Closes #1594
Closes #1670

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@costrouc
Copy link
Member Author

costrouc commented Apr 7, 2023

I've tested this out locally. I've tested every feature except the ability to access the keycloak console without root credentials.

Users need to visit https://<domain>/auth/admin/nebari/console/

@costrouc costrouc requested a review from iameskild April 10, 2023 16:54
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

Just to confirm what will happen for existing users:

  • the existing Keycloak groups will be unaffected but a new superadmin group will now also be available
  • their conda-store configmap will be updated
  • the version of conda-store will be updated and this shouldn't affect existing environments

If there's anything else that I might've missed, feel free to let me know :)

@costrouc costrouc added the needs: review 👀 This PR is complete and ready for reviewing label Apr 10, 2023
@costrouc
Copy link
Member Author

@iameskild yes exactly. In addition the admin group can now edit users/groups in keycloak with permissions.

@iameskild iameskild merged commit daecbcf into develop Apr 10, 2023
@iameskild iameskild deleted the conda-store-update branch April 10, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
2 participants