Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nebari invocation through python #1711

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Apr 12, 2023

What does this implement/fix?

In its current state, python -m nebari ... does not work, since the imports fail. The whole point of the __main__ file is to enable that. This PR fixes the imports and adds a test to avoid the same issue in the future.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@pavithraes pavithraes added type: bug 🐛 Something isn't working needs: review 👀 This PR is complete and ready for reviewing labels Apr 12, 2023
@pavithraes pavithraes requested a review from iameskild April 12, 2023 13:32
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pmeier :)

@iameskild
Copy link
Member

/bot run tests

@pmeier pmeier mentioned this pull request Apr 21, 2023
10 tasks
@pavithraes pavithraes added the status: blocked ⛔️ This item is on hold due to another task label Apr 24, 2023
@iameskild iameskild removed the status: blocked ⛔️ This item is on hold due to another task label Apr 24, 2023
@iameskild iameskild merged commit 37226b7 into nebari-dev:develop Apr 24, 2023
@pmeier pmeier deleted the fix-python-invocation branch April 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing type: bug 🐛 Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants