Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributor trigger #1765

Merged
merged 2 commits into from
May 1, 2023
Merged

Fix contributor trigger #1765

merged 2 commits into from
May 1, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 1, 2023

Reference Issues or PRs

What does this implement/fix?

  • Addresses Fix? contributor test trigger #1734 (comment) after a premature merge

  • Temporarily disables provider tests due to permissions issues, e.g. https://github.com/nebari-dev/nebari/actions/runs/4854682354 While we need to fix this in the long run, this is not a regression, since nothing works ATM

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds a feature)

  • Breaking change (fix or feature that would cause existing features not to work as expected)

  • Documentation Update

  • Code style update (formatting, renaming)

  • Refactoring (no functional changes, no API changes)

  • Build related changes

  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pmeier pmeier requested a review from iameskild May 1, 2023 20:39
@pmeier pmeier merged commit c28e506 into nebari-dev:develop May 1, 2023
@pmeier pmeier deleted the contrib-trigger branch May 1, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants