Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn warnings into errors with pytest #1774

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 2, 2023

Reference Issues or PRs

Implements #1700 (comment) after #1700 (comment).

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@pavithraes pavithraes added type: maintenance 🛠 Day-to-day maintenance tasks status: approved 💪🏾 This PR has been reviewed and approved for merge labels May 3, 2023
@pavithraes pavithraes merged commit ac981ea into nebari-dev:develop May 3, 2023
@pmeier pmeier deleted the w2e branch May 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved 💪🏾 This PR has been reviewed and approved for merge type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

2 participants