Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purge setup.cfg #1781

Merged
merged 1 commit into from
May 3, 2023
Merged

purge setup.cfg #1781

merged 1 commit into from
May 3, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 3, 2023

What does this implement/fix?

We no longer use setuptools since #1545, but setup.cfg is still mentioned in several places inside the repository. This PR fixes that.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

iameskild
iameskild approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmeier pmeier merged commit 7653c67 into nebari-dev:develop May 3, 2023
@pmeier pmeier deleted the setup.cfg branch May 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area:developer-experience 👩🏻‍💻 area: testing ✅ Testing
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmeier @iameskild