Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document that the upgrade command is for all nebari upgrades #1794

Merged
merged 4 commits into from
May 9, 2023
Merged

document that the upgrade command is for all nebari upgrades #1794

merged 4 commits into from
May 9, 2023

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented May 8, 2023 •
edited
Loading

Reference Issues or PRs

Fixes the CLI issue mentiond at #1790. Users need to run nebari upgrade to upgrade nebari now, so the CLI help text should reflect that.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

pmeier
pmeier reviewed May 9, 2023
View reviewed changes
nebari/cli/main.py Outdated Show resolved Hide resolved
@Adam-D-Lewis @pmeier
Update nebari/cli/main.py
fdf7d65 
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
@Adam-D-Lewis Adam-D-Lewis requested a review from pmeier May 9, 2023 14:57
pmeier
pmeier approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Thanks Adam!

@Adam-D-Lewis Adam-D-Lewis merged commit 8bd56f9 into develop May 9, 2023
@Adam-D-Lewis Adam-D-Lewis deleted the upgrade_cli_fix branch May 9, 2023 15:32
@pavithraes pavithraes added status: approved 💪🏾 This PR has been reviewed and approved for merge area: documentation 📖 Improvements or additions to documentation type: maintenance 🛠 Day-to-day maintenance tasks area: nebari-cli labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@iameskild iameskild Awaiting requested review from iameskild

@kcpevey kcpevey Awaiting requested review from kcpevey

Assignees
No one assigned
Labels
area: documentation 📖 Improvements or additions to documentation area: nebari-cli status: approved 💪🏾 This PR has been reviewed and approved for merge type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adam-D-Lewis @pmeier @pavithraes