Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge most danlging qhub references #1802

Merged
merged 5 commits into from
May 20, 2023
Merged

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 10, 2023

While only very few, there are a some references to QHub left in the repository. This PR updates most of them. The ones left are

  • inside the RELEASE.md file: we obviously can't remove them
  • inside nebari/upgrade.py or test/test_upgrade.py: same as above
  • inside the docs/ directory: handled by purge docs and nox #1801
  • inside tests_e2e/cypress: since test is green now and playwright (Initial playwright setup #1665) will replace the cypress tests soon, I just left it

What does this implement/fix?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

README.md Outdated Show resolved Hide resolved
@pmeier pmeier marked this pull request as ready for review May 10, 2023 21:39
@pmeier pmeier added area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing area:developer-experience 👩🏻‍💻 labels May 15, 2023
@pmeier pmeier requested a review from pavithraes May 15, 2023 15:23
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier! I made one minor suggested change but otherwise, this can be merged :)

nebari/utils.py Outdated Show resolved Hide resolved
pmeier and others added 2 commits May 19, 2023 08:48
Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com>
@pmeier pmeier merged commit 4111625 into nebari-dev:develop May 20, 2023
@pmeier pmeier deleted the purge-qhub branch May 20, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:developer-experience 👩🏻‍💻 area: documentation 📖 Improvements or additions to documentation needs: review 👀 This PR is complete and ready for reviewing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants