Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge infracost CLI command / CI jobs #1820

Merged
merged 2 commits into from
May 24, 2023
Merged

purge infracost CLI command / CI jobs #1820

merged 2 commits into from
May 24, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented May 22, 2023

What does this implement/fix?

Addresses #1817 (comment).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This is removing the nebari cost command and thus is breaking. However, this was marked "experimental"

[italic]This is still only experimental using Infracost under the hood.

and thus there are no BC concerns here.

@pmeier pmeier requested review from dharhas and iameskild May 22, 2023 19:47
@pavithraes pavithraes added needs: review 👀 This PR is complete and ready for reviewing type: maintenance 🛠 Day-to-day maintenance tasks labels May 23, 2023
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Infracost is a neat tool but doesn't really fully capture the cost of running Nebari so it has limited utility for us and I don't think it's worth the maintenance burden.

Thanks @pmeier!

@pmeier pmeier merged commit 550ee1c into develop May 24, 2023
@pmeier pmeier deleted the purge-infracost branch May 24, 2023 19:50
@pavithraes pavithraes removed the needs: review 👀 This PR is complete and ready for reviewing label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

3 participants