Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argo-viewer service account reference #1881

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Fix argo-viewer service account reference #1881

merged 1 commit into from
Aug 2, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

When launching a jupyterlab server, user's in the analyst group (and not in the developer/admin groups) run into the following error:

Error: secret "argo-view.service-account-token" not found

This is due to a mislabeling of the argo-viewer service account token.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested a review from a team August 2, 2023 06:25
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@iameskild iameskild merged commit 63b613a into develop Aug 2, 2023
@iameskild iameskild deleted the 20230801eae branch August 2, 2023 18:44
@iameskild iameskild restored the 20230801eae branch August 2, 2023 18:45
@dcmcand dcmcand deleted the 20230801eae branch February 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants