Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure path is Path object #1888

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Ensure path is Path object #1888

merged 2 commits into from
Aug 4, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Bug fix: the path object is assumed to be a pathlib.Path object. This fix ensure that this is indeed the case.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested a review from costrouc August 4, 2023 05:43
@iameskild iameskild requested a review from a team August 4, 2023 05:47
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd be in favor of making path: Path = None and just requiring that the function is called with a pathlib object so we don't need a conditional statement.

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costrouc costrouc merged commit 92af1cd into develop Aug 4, 2023
@costrouc costrouc deleted the 20230803eae branch August 4, 2023 17:02
iameskild added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants