Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest:ensure failure on warnings #1907

Merged
merged 2 commits into from
Aug 15, 2023
Merged

pytest:ensure failure on warnings #1907

merged 2 commits into from
Aug 15, 2023

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 14, 2023 •
edited
Loading

This PR will revert changes that were introduced in the extension branch being merged. Ignoring warnings and especially deprecation warnings in the tests will only lead to problems down the line

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

@costrouc
Ensure failure on warnings
a3121be 
Ignoring warnings and especially deprecation warnings in the tests will only lead to problems down the line
@pavithraes pavithraes added needs: review 👀 This PR is complete and ready for reviewing area: CI/CD 👷🏽‍♀️ type: maintenance 🛠 Day-to-day maintenance tasks labels Aug 14, 2023
@pavithraes pavithraes requested a review from pmeier August 14, 2023 12:32
@costrouc costrouc changed the title Ensure failure on warnings pytest:ensure failure on warnings Aug 14, 2023
@costrouc
Copy link
Member Author

This PR should be merged only once the CI is green again (guessing about 1 week out from now).

@pavithraes pavithraes added status: blocked ⛔️ This item is on hold due to another task and removed needs: review 👀 This PR is complete and ready for reviewing labels Aug 14, 2023
@iameskild
Copy link
Member

Closing in favor of #1908

@iameskild iameskild closed this Aug 14, 2023
@pmeier
Copy link
Member

pmeier commented Aug 14, 2023

@iameskild #1908 is merged and does not contain the diff from this PR or something similar. Did I miss anything or should we reopen?

@costrouc costrouc reopened this Aug 15, 2023
@costrouc
Copy link
Member Author

Re-opened and updated PR to run latest on develop

pmeier
pmeier approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green so this LGTM. Thanks @costrouc!

@pmeier pmeier merged commit 4299969 into develop Aug 15, 2023
@pmeier pmeier deleted the revert-changes-to-pytestini branch August 15, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
area: CI/CD 👷🏽‍♀️ status: blocked ⛔️ This item is on hold due to another task type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@costrouc @iameskild @pmeier @pavithraes