Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for mixed string/posixpath error #1915

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Reference Issues or PRs

Fixes #1914

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Technically fixes the issue, but more of a workaround

@sblair-metrostar
Copy link
Contributor Author

@iameskild @costrouc This draft has my working fixes for a couple of other issues as well, #1919 and #1916 so far.

@iameskild iameskild marked this pull request as ready for review August 17, 2023 19:19
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes @sblair-metrostar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Nebari render fails on develop/extensions due to mismatched PosixPath and strings
2 participants