Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup step for AWS integration test, ensure diable_prompt is passed through #1921

Merged
merged 22 commits into from
Aug 22, 2023
Merged

Add cleanup step for AWS integration test, ensure diable_prompt is passed through #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4097470
Add unit tests for config.py
iameskild Aug 14, 2023
11237f2
Clean up
iameskild Aug 14, 2023
b83d9b2
Clean up digital_ocean deployment
iameskild Aug 15, 2023
83e8faf
Fix type hint
iameskild Aug 15, 2023
745a1a8
Merge branch 'develop' into 20230814
iameskild Aug 16, 2023
171c395
Use disable_prompt instead of kwargs
iameskild Aug 16, 2023
28206e5
Add dns to config for integration test fixture
iameskild Aug 16, 2023
a1ec497
Initial aws deployment clean
iameskild Aug 17, 2023
6b345e8
merge develop
iameskild Aug 17, 2023
1ef7995
merge develop
iameskild Aug 18, 2023
adf3662
Finish aws_cleanup function
iameskild Aug 18, 2023
c87a065
Merge branch '20230814' into 20230816
iameskild Aug 18, 2023
a309630
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] Aug 18, 2023
fdb5d49
Clean up
iameskild Aug 18, 2023
51d2ebe
Add option to use aws_session_token
iameskild Aug 18, 2023
21765b6
Add another disable_prompt
iameskild Aug 18, 2023
0438adf
Fix
iameskild Aug 18, 2023
9b92f6c
Merge branch 'develop' into 20230814
iameskild Aug 21, 2023
717b2ac
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] Aug 21, 2023
e3695e2
Merge branch '20230814' into 20230816
iameskild Aug 21, 2023
715c116
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] Aug 21, 2023
ce9fd8e
Merge develop
iameskild Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/_nebari/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@
def deploy_configuration(
config: schema.Main,
stages: List[hookspecs.NebariStage],
dns_provider,
dns_auto_provision,
disable_prompt: bool = False,
disable_checks: bool = False,
skip_remote_state_provision: bool = False,
):
if config.prevent_deploy:
raise ValueError(
Expand Down Expand Up @@ -53,7 +50,7 @@ def deploy_configuration(
with contextlib.ExitStack() as stack:
for stage in stages:
s = stage(output_directory=pathlib.Path.cwd(), config=config)
stack.enter_context(s.deploy(stage_outputs))
stack.enter_context(s.deploy(stage_outputs, disable_prompt))

if not disable_checks:
s.check(stage_outputs)
Expand Down
Loading