Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nebari cli environment variable handling, support, keycloak, dev tests #1968

Merged
merged 11 commits into from
Sep 4, 2023
Merged

nebari cli environment variable handling, support, keycloak, dev tests #1968

merged 11 commits into from
Sep 4, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Reference Issues or PRs

#1955

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Unit tests

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@sblair-metrostar sblair-metrostar changed the title nebari cli environment variable handling tests nebari cli environment variable handling, support tests Aug 31, 2023
@sblair-metrostar sblair-metrostar changed the title nebari cli environment variable handling, support tests nebari cli environment variable handling, support, keycloak, dev tests Sep 1, 2023
iameskild
iameskild approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @sblair-metrostar!

@iameskild iameskild merged commit 157aae9 into nebari-dev:develop Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area: nebari-cli area: testing ✅ Testing
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sblair-metrostar @iameskild @kenafoster