Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to generate_cli_docs workflow #2005

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

The API docs PR introduced a workflow to check for changes to the CLI, and if changes exist, that workflow will open a PR against the nebari-docs repo. This PR simply gives the workflow the required permissions to create this PR.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild changed the title Add permissions to workflow Add permissions to generate_cli_docs workflow Sep 12, 2023
@iameskild iameskild requested a review from kcpevey September 12, 2023 21:37
@iameskild
Copy link
Member Author

@kcpevey we're seeing a new [AUTO] Update CLI docs PR for ever PR opened so I modified this workflow to only run when CLI related files are touched.

Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iameskild iameskild merged commit 23e1651 into develop Sep 13, 2023
@iameskild iameskild deleted the docs/fix_generate_cli_doc branch September 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants