Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli init repo auto provision fix #2012

Merged
merged 9 commits into from
Sep 19, 2023
Merged

cli init repo auto provision fix #2012

merged 9 commits into from
Sep 19, 2023

Conversation

sblair-metrostar
Copy link
Contributor

Reference Issues or PRs

Fixes #1936

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added area: authentication area: nebari-cli project: JATIC Work item needed for the JATIC project labels Sep 14, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 18, 2023
iameskild
iameskild approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again @sblair-metrostar!

@iameskild
Copy link
Member

@sblair-metrostar could you please resolve the merge conflicts? I don't have permissions to push to your remote branch.

@iameskild iameskild merged commit d58ebb1 into nebari-dev:develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area: authentication area: nebari-cli project: JATIC Work item needed for the JATIC project
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.10.1
Development

Successfully merging this pull request may close these issues.

[BUG] - Nebari init with --repository-auto-provision --repository github.com fails on validation error
2 participants
@sblair-metrostar @iameskild