Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: enable exact_match config in playwright notebook test #2027

Merged
merged 14 commits into from
Oct 18, 2023
Merged

TST: enable exact_match config in playwright notebook test #2027

merged 14 commits into from
Oct 18, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 22, 2023 •
edited
Loading

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This PR requires some change to #1996, so merge after it.

@fangchenli fangchenli added area: testing ✅ Testing needs: review 👀 This PR is complete and ready for reviewing labels Sep 22, 2023
@fangchenli fangchenli mentioned this pull request Sep 22, 2023
Closed
10 tasks
@fangchenli fangchenli marked this pull request as draft September 24, 2023 18:01
@fangchenli fangchenli marked this pull request as ready for review October 15, 2023 04:59
iameskild
iameskild approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests 👍

@iameskild iameskild merged commit 20bc7d4 into nebari-dev:develop Oct 18, 2023
8 checks passed
@fangchenli fangchenli deleted the playwright-exact-match branch October 22, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area:developer-experience 👩🏻‍💻 area: testing ✅ Testing needs: review 👀 This PR is complete and ready for reviewing
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @iameskild