Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: specify required field when retrieving available gcp regions #2033

Merged
merged 7 commits into from
Nov 8, 2023
Merged

ENH: specify required field when retrieving available gcp regions #2033

merged 7 commits into from
Nov 8, 2023

Conversation

fangchenli
Copy link
Member

Reference Issues or PRs

This is a precursor for #1928.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added provider: GCP type: enhancement 💅🏼 New feature or request type: maintenance 🛠 Day-to-day maintenance tasks and removed type: enhancement 💅🏼 New feature or request labels Oct 13, 2023
@iameskild iameskild added this to the The Release After Next milestone Oct 18, 2023
iameskild
iameskild approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iameskild iameskild merged commit 748bb6a into nebari-dev:develop Nov 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
provider: GCP type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @iameskild