Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix validation error related to provider #2054 #2056

Merged
merged 15 commits into from
Oct 16, 2023
Merged

BUG: fix validation error related to provider #2054 #2056

merged 15 commits into from
Oct 16, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 9, 2023 •
edited
Loading

Reference Issues or PRs

close #2054

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

fangchenli
fangchenli commented Oct 9, 2023
View reviewed changes
tests/tests_unit/test_cli_upgrade.py
Comment on lines -258 to -259
assert "provider" in str(result.exception)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test here because it's not asserting the expected behavior, also the exception was raised before any upgrade steps, so it's not related to upgrade.

iameskild
iameskild reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a closer look at this! I know you also have the PR open to upgrade to Pydantic v2 so hopefully these changes are too painful.

tests/tests_unit/test_schema.py Outdated Show resolved Hide resolved
src/_nebari/stages/infrastructure/__init__.py Outdated Show resolved Hide resolved
@iameskild iameskild added area: testing ✅ Testing type:extension Nebari Extension labels Oct 9, 2023
iameskild
iameskild approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli!

src/_nebari/stages/infrastructure/__init__.py Show resolved Hide resolved
@fangchenli fangchenli mentioned this pull request Oct 13, 2023
Closed
@iameskild
Copy link
Member

Thanks again @fangchenli, feel free to merge when you're ready.

@fangchenli fangchenli merged commit 4db8400 into nebari-dev:develop Oct 16, 2023
9 checks passed
@fangchenli fangchenli deleted the validation-main branch October 16, 2023 06:44
This was referenced Oct 24, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

Assignees
No one assigned
Labels
area: testing ✅ Testing type:extension Nebari Extension
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Wrong error raised when an invalid provider is given
2 participants
@fangchenli @iameskild