Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block usage of pip inside jupyterlab #2191

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Jan 10, 2024

Reference Issues or PRs

closes #2133

What does this implement/fix?

This update adds a blocking configuration (globally applied) to the pip command, where its usage will only be habilitated if the user uses a virtualenv, which we can assume the user will not attempt as we already provide the conda environments for such needs.

As an environment variable controls this, it's still possible to be overridden by the user if the variable's value is modified.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Tested within a local deployment:

  • from within a notebook:
    image
  • from terminal:
    image

obs.: tested within all envs to make sure it was supplied as a global update

@viniciusdc viniciusdc requested a review from costrouc January 10, 2024 17:08
@viniciusdc
Copy link
Contributor Author

I will figure out why local failed later today

@costrouc
Copy link
Member

@viniciusdc have you tested this PR out locally to see if this works?

@costrouc
Copy link
Member

Updating branch to rerun ci

@viniciusdc
Copy link
Contributor Author

@viniciusdc have you tested this PR out locally to see if this works?

Tested locally, screenshots in the description

@pavithraes pavithraes added this to the 2024.1.1 milestone Jan 16, 2024
@pavithraes pavithraes added the status: in review 👀 This PR is currently being reviewed by the team label Jan 16, 2024
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @viniciusdc for testing this out. Playwright is failing due to jupyterlab ui changes that do not affect this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in review 👀 This PR is currently being reviewed by the team
Projects
Development

Successfully merging this pull request may close these issues.

Isolate .local (i.e. pip) installations for each environment
3 participants