Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fields to ignore within keycloak_realm #2200

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

costrouc
Copy link
Member

Closes #2180

This PR uses the lifecycle.ignore_changes terraform attrribute which allows setting terraform to ignore if certain attributes are modified. I have tested this locally to work.

ignore_changes also supports an all parameter but this would set terraform to ignore all attributes in the resource which we do not want.

@costrouc costrouc requested a review from kenafoster January 11, 2024 17:29
@costrouc costrouc added this to the 2024.1.1 milestone Jan 11, 2024
@costrouc costrouc added status: in progress 🏗 This task is currently being worked on area: integration/keycloak type: enhancement 💅🏼 New feature or request labels Jan 11, 2024
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dcmcand dcmcand merged commit 52f5927 into develop Jan 11, 2024
26 of 27 checks passed
@dcmcand dcmcand deleted the feat-keycloak-ignore-fields branch January 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: integration/keycloak status: in progress 🏗 This task is currently being worked on type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Prevent SMTP realm settings from being wiped by terraform
3 participants