Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jhub-client from pyproject.toml #2242

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

pavithraes
Copy link
Member

Reference Issues or PRs

The Jupyter Notebook tests that used jhub-client were removed in #2232. This PR removes jhub-client as a dependency, because I don't believe we use it anywhere else.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@pavithraes pavithraes added type: maintenance 🛠 Day-to-day maintenance tasks area: dependencies 📦 All things dependencies labels Feb 13, 2024
@marcelovilla
Copy link
Member

Good catch @pavithraes! I did not even think about this when removing the Notebook tests. Thank you!

@pavithraes pavithraes added this to the 2024.2.1 milestone Feb 14, 2024
@pavithraes pavithraes merged commit 858ca5f into develop Feb 14, 2024
28 checks passed
@pavithraes pavithraes deleted the pavithraes-patch-1 branch February 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies type: maintenance 🛠 Day-to-day maintenance tasks
Projects
Development

Successfully merging this pull request may close these issues.

2 participants