Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose jupyter's preferred dir as a config option #2251

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 15, 2024

Reference Issues or PRs

Closes #2250

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update: Document jupyterlab.preferred_dir nebari-docs#408
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@krassowski krassowski marked this pull request as ready for review February 15, 2024 15:02
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aktech aktech merged commit 32f62f8 into nebari-dev:develop Feb 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Support setting preferred directory for Jupyter
2 participants