Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud provider to the dask config.json file #2266

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

Closes #2265

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Special shout-out to @viniciusdc for identifying the issue and guiding me through the process of solving it.

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the bug @marcelovilla !! (feel free to merge if you would like to include in the RC)

@marcelovilla marcelovilla merged commit 5463e8d into develop Feb 20, 2024
27 checks passed
@marcelovilla marcelovilla deleted the fix-dask-json branch February 20, 2024 20:30
@pavithraes pavithraes added this to the 2024.2.1 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - Failing to create a new dask cluster
3 participants