Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Open VS Code" entry in services #2267

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Together with nebari-dev/jupyterlab-nebari-mode#1 fixes #2217

What does this implement/fix?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

See integration tests in nebari-dev/jupyterlab-nebari-mode#1.

Any other comments?

@krassowski
Copy link
Member Author

This can be tested with a docker image including jupyterlab-nebari-mode==0.2.0, and should be safe to merge even for users of docker images which do not include jupyterlab-nebari-mode because because when the command is not available the added menu item will simply not show up (without any side effects).

@marcelovilla
Copy link
Member

@krassowski should we pin jupyterlab-nebari-mode to 0.2.0 in https://github.com/nebari-dev/nebari-docker-images/blob/main/jupyterlab/environment.yaml and then start upgrading as we release new versions?

@krassowski
Copy link
Member Author

Thanks! I opened nebari-dev/nebari-docker-images#123

@krassowski
Copy link
Member Author

Is it ok to merge this one?

@marcelovilla
Copy link
Member

@krassowski yes, let's merge it so it makes the next release

@marcelovilla marcelovilla merged commit 50e2f8a into nebari-dev:develop Mar 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - VSCode missing from the "nebari" top menu
2 participants