Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmcandrew update ruamel.yaml #2315

Merged
merged 22 commits into from
Mar 19, 2024
Merged

Dmcandrew update ruamel.yaml #2315

merged 22 commits into from
Mar 19, 2024

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Mar 13, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

tylergraff and others added 17 commits March 12, 2024 15:57
@dcmcand dcmcand marked this pull request as ready for review March 19, 2024 13:54
marcelovilla
marcelovilla approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

My only suggestion is we update the Python version in the docs too: https://github.com/nebari-dev/nebari-docs/blob/b436c7e09f874665f9379ee2fff0c5e249ae5cd0/docs/docs/get-started/installing-nebari.md?plain=1#L22

marcelovilla
marcelovilla reviewed Mar 19, 2024
View reviewed changes
.github/workflows/test_conda_build.yaml Outdated
@@ -54,5 +54,4 @@ jobs:
conda build nebari
- name: Test nebari
run: |
conda install --use-local nebari
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcmcand why did you remove the install? Isn't it needed for nebari to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was installing the wrong version.

@dcmcand dcmcand merged commit c2528dd into develop Mar 19, 2024
27 checks passed
@dcmcand dcmcand deleted the dmcandrew-update-ruamel.yaml branch March 19, 2024 16:08
This was referenced Mar 19, 2024
Merged
Closed
@viniciusdc viniciusdc added this to the 2024.3.3 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

@Adam-D-Lewis Adam-D-Lewis Awaiting requested review from Adam-D-Lewis

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2024.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dcmcand @marcelovilla @viniciusdc @tylergraff