get default variable value when following a terraform variable #2322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
This part of the release process was failing with error
ValueError: Could not find loki:{'description': 'version to deploy for the loki helm chart', 'type': '${string}', 'default': '5.43.3'} directory in helm_charts.
. chart_version was being set to{'description': 'version to deploy for the loki helm chart', 'type': '${string}', 'default': '5.43.3'}
instead of '5.43.3'. This became an issue with the recent addition of loki.I tested the change locally and it seems to run fine. I'm not sure if there are other use cases where we would not want to grab the default value, but it does seem to run successfully when I run it locally. Asking @viniciusdc to review since I believe he originally implemented this and may have more insight.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?