Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get default variable value when following a terraform variable #2322

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 14, 2024

Reference Issues or PRs

This part of the release process was failing with error ValueError: Could not find loki:{'description': 'version to deploy for the loki helm chart', 'type': '${string}', 'default': '5.43.3'} directory in helm_charts.. chart_version was being set to {'description': 'version to deploy for the loki helm chart', 'type': '${string}', 'default': '5.43.3'} instead of '5.43.3'. This became an issue with the recent addition of loki.

I tested the change locally and it seems to run fine. I'm not sure if there are other use cases where we would not want to grab the default value, but it does seem to run successfully when I run it locally. Asking @viniciusdc to review since I believe he originally implemented this and may have more insight.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests? No

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from viniciusdc March 14, 2024 15:53
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see any problems with using the variable's default value. The primary purpose of this was to catch any issues with the default versions and avoid situations where the helm is no longer available.

@Adam-D-Lewis Adam-D-Lewis merged commit 366d1cd into develop Mar 14, 2024
27 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the fix_helm_validate branch March 14, 2024 17:56
@viniciusdc viniciusdc added this to the 2024.3.3 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants