Deduplicate conda-store in JupyterLab main menu

[krassowski]

Reference Issues or PRs

• Fixes [BUG] - Conda store shows up in two places in menu bar #2326.
• Depends on Upgrade jupyterlab-nebari-mode to 0.3.0 nebari-docker-images#130

Uses jupyterlab-conda-store if available, fallbacks to opening /conda-store in new browser tab otherwise. The label in each case is set to "Environment Manager" (but we can adjust it).

Before

• "Services > Environment Management" coming from nebari and opening conda-store in a new tab:
  
• "Conda-Store > Conda Store Package Manager" coming from jupyterlab-conda-store:
  

After

• single "Services > Environment Manager" which opens jupyterlab-conda-store if available or /conda-store in new tab otherwise.

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

[dcmcand]

Thanks @krassowski

[viniciusdc]

LGTM as well, though just to make sure, this is used when the user opts for installing the extension what happens when the extension is not available?

[viniciusdc]

Without this, does the extension still opens as a separate tab?

[krassowski]

That code was opening the /conda-store in a new browser tab.

[viniciusdc]

Hi @krassowski thanks for this, could you explain a bit how this works? does this call the extension, or the endpoint for the conda-store webpage as well?

[krassowski]

It opens conda-store-ui as a tab in jupyterlab main area:

[krassowski]

this is used when the user opts for installing the extension what happens when the extension is not available?

The extension is included in the default docker image, so there is no opting-in. When extension is not available because user admin opts-out, the menu item is not show, but the other menu items are shown.

We could have it both ways: when extension is available, open it as a JupyterLab tab; when extension is not available open it in a new browser tab. I can make this work straightaway by adding some logic in jupyterlab-nebari-mode.

[krassowski]

A dedicated logic (new command) in jupyterlab-nebari-mode would also allow to change the label so maybe it is desirable.

[viniciusdc]

A dedicated logic (new command) in jupyterlab-nebari-mode would also allow to change the label so maybe it is desirable.

Yes, I agree. I was also trying to lean towards this, as we would be able to keep the names "non-dependent" on the extension itself. Would you be able to include these changes as part of this PR, or do you prefer if this is a separate step?

[krassowski]

Would you be able to include these changes as part of this PR, or do you prefer if this is a separate step?

I will include the changes here. It will require bumping the pin to jupyterlab-nebari-mode on docker images, I will drop a link to PR when ready.

[krassowski]

Done. I updated top-level issue. This now depends on nebari-dev/nebari-docker-images#130. Tested locally with the new image. Recording:

[krassowski]

Is this and nebari-dev/nebari-docker-images#130 good to merge?

[viniciusdc]

LGTM!!