Set node affinity for more pods to ensure they run on general node pool #2353
Conversation
| configuration_values = jsonencode({ | ||
| controller = { | ||
| nodeSelector = { | ||
| "eks.amazonaws.com/nodegroup" = "general" |
There was a problem hiding this comment.
I'd like to pass this is as a variable rather than hard code it (as in src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/main.tf)
There was a problem hiding this comment.
I actually don't think we support renaming node pools so I'm fine adding this as is.
|
|
||
| configuration_values = jsonencode({ | ||
| nodeSelector = { | ||
| "eks.amazonaws.com/nodegroup" = "general" |
There was a problem hiding this comment.
I actually don't think we support renaming node pools so I'm fine adding this as is.
| { | ||
| key = "eks.amazonaws.com/nodegroup" | ||
| operator = "In" | ||
| values = ["general"] |
There was a problem hiding this comment.
I actually don't think we support renaming node pools so I'm fine adding this as is.
| affinity = { | ||
| nodeAffinity = { | ||
| requiredDuringSchedulingIgnoredDuringExecution = { | ||
| nodeSelectorTerms = [ | ||
| { | ||
| matchExpressions = [ | ||
| { | ||
| key = var.node-group.key | ||
| operator = "In" | ||
| values = [var.node-group.value] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
Adam-D-Lewis
requested review from
aktech,
marcelovilla,
viniciusdc and
dcmcand
| @@ -57,7 +57,6 @@ resource "aws_eks_node_group" "main" { | |||
| ] | |||
|
|
|||
| tags = merge({ | |||
| # "kubernetes.io/cluster/${var.name}" = "shared" | |||
There was a problem hiding this comment.
fly by, removing commented out code
|
Ready for Review! |
There was a problem hiding this comment.
🚀 thanks for getting this over the finish line @Adam-D-Lewis and thanks for the work here @sblair-metrostar
Reference Issues or PRs
Supercedes #2214
Solves
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?