Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to deprecated cdsdashboards #2390

Merged
merged 3 commits into from
Apr 10, 2024
Merged

remove references to deprecated cdsdashboards #2390

merged 3 commits into from
Apr 10, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 10, 2024 •
edited
Loading

Reference Issues or PRs

remove references to deprecated cdsdashboards

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

marcelovilla
marcelovilla approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Adam-D-Lewis Adam-D-Lewis merged commit f3028b7 into develop Apr 10, 2024
25 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the deprecation branch April 10, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adam-D-Lewis @marcelovilla