Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update concurrency settings for Integration tests #2393

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Update concurrency settings for Integration tests #2393

merged 4 commits into from
Apr 18, 2024

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

#2386

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@viniciusdc
Copy link
Contributor Author

ref. for working config https://github.com/nebari-dev/nebari/actions/runs/8651753113

@viniciusdc viniciusdc requested review from aktech and a team April 11, 2024 18:53
@viniciusdc viniciusdc added this to the 2024.4.1 milestone Apr 12, 2024
marcelovilla
marcelovilla approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

aktech
aktech reviewed Apr 12, 2024
View reviewed changes
.github/workflows/test_local_integration.yaml
@@ -34,14 +34,16 @@ on:
required: true
type: string

concurrency:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line here to explain what's the expected behaviour?

Copy link
Contributor Author

@viniciusdc viniciusdc Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aktech let me know if this helps (added some description)

@marcelovilla marcelovilla merged commit 91c6825 into develop Apr 18, 2024
4 checks passed
@marcelovilla marcelovilla deleted the 2386-integration-concurrency branch April 18, 2024 22:33
@marcelovilla marcelovilla mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech left review comments

@marcelovilla marcelovilla marcelovilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2024.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@viniciusdc @aktech @marcelovilla