Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make userscheduler run on general node group #2415

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 18, 2024

Reference Issues or PRs

Fixes #2414

Tagging @pt247, I'm confident this won't affect the "dedicated" stuff for AWS that he implemented recently, but if @pt247 could give it a quick check over and confirm I'd appreciate it. Thanks!

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested review from pt247 and a team April 18, 2024 23:03
@Adam-D-Lewis Adam-D-Lewis added the needs: review 👀 This PR is complete and ready for reviewing label Apr 19, 2024
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like to have @pt247 to have a look as well before merging

@pt247
Copy link
Contributor

pt247 commented Apr 22, 2024

LGTM
cc @Adam-D-Lewis , @viniciusdc

@Adam-D-Lewis Adam-D-Lewis merged commit 0c3adc8 into develop Apr 22, 2024
26 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the gen_usched branch April 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] - User scheduler pods run on user node groups on GCP, Azure, DO deployments
3 participants