-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload identity #2460
Workload identity #2460
Changes from 150 commits
14125a3
48f26ba
b57c75f
250be86
7912e37
4eb1e08
553d021
9febc8a
8e33010
99cb520
8fb92ff
0967d52
1692797
bd76c4d
708d165
2f99cac
82ec511
aba88ec
3e645b4
ff0682e
eaab189
fb90cc6
b085e49
e520dcc
91fb5b4
5d0fca4
2935c1f
961a278
f725534
c543bdd
6b98638
2f3bbae
ef8dfb4
a9d8d71
e920e5b
19af132
819abe9
d0c07e8
f3c518e
bfba588
70a5803
afaf06a
f6c8468
eb5afa7
292087a
ec2417c
f4aeef2
41699ea
27ca9ff
70c8f6c
7b695f0
dbf5157
ac0b6ae
a770d2a
5e57a3a
7481469
bc3f5f6
4ff3236
22bef83
e41f3a7
2d0ee62
7d42def
2f6cb7f
bd50f0b
a30760a
ba53843
6532f6a
8949cfe
64d5943
6c166cd
acc7ebd
4dfd46c
f3775d7
842de7b
e4b458c
a443deb
69ea483
bc79fd6
2da0b89
ed1329d
9f648c0
8236673
ae7d918
b141ff3
deada6e
b3b5268
3831b51
b77a59a
f14529a
3e46486
33fde03
ec07870
5c50185
47b86eb
5cef9ce
7c5b5cc
d74d69d
44c9f71
12f5288
88d8bc4
bbdf6f2
b2891d1
0e4d7fd
845becb
b01446e
0df2e64
33f4712
4a80f23
4d824be
6e330e5
88b46a8
924659d
75d8e70
a8bab5c
35252ef
436dab7
283150f
b2dbbd9
082cc41
3d6726f
7e5891f
32ee7ba
e1030d8
850de95
6b2b629
473a1ee
9d9fd49
c4b8c6e
89e73aa
680ce25
c8feabc
52b4ea8
2b38f46
a46cf1d
d4f301d
8881d7c
b88aa1b
992ae28
e904428
261f43a
e48e3a4
e7faa3a
a0ab2a4
0e41fca
91f9e00
92a27f7
240b6dc
f172e8b
cbb82e0
dc84aac
47b40ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,13 @@ output "kubeconfig" { | |
sensitive = true | ||
value = azurerm_kubernetes_cluster.main.kube_config_raw | ||
} | ||
|
||
output "cluster_oidc_issuer_url" { | ||
description = "The OpenID Connect issuer URL that is associated with the AKS cluster" | ||
value = azurerm_kubernetes_cluster.main.oidc_issuer_url | ||
} | ||
Comment on lines
+21
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It returns null |
||
|
||
output "resource_group_name" { | ||
description = "The name of the resource group in which the AKS cluster is created" | ||
value = azurerm_kubernetes_cluster.main.resource_group_name | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,7 +144,7 @@ resource "kubernetes_manifest" "forwardauth-middleware" { | |
apiVersion = "traefik.containo.us/v1alpha1" | ||
kind = "Middleware" | ||
metadata = { | ||
name = "traefik-forward-auth" | ||
name = var.forwardauth_middleware_name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I got this correctly, you just created an output for the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We previously hard coded the forward auth middleware name. I added a variable for it (not strictly necessary for what I needed with mlflow plugin). I also created an output for whatever name is chosen. This was necessary for an mlflow plugin. I needed to put authentication in front of the mlflow pod so I re-use the existing forward auth service, middleware, and pod. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool! The reason I asked was because DaskGateway also uses it, so I just wanted to make sure that the service would still work |
||
namespace = var.namespace | ||
} | ||
spec = { | ||
|
@@ -175,7 +175,7 @@ resource "kubernetes_manifest" "forwardauth-ingressroute" { | |
|
||
middlewares = [ | ||
{ | ||
name = "traefik-forward-auth" | ||
name = kubernetes_manifest.forwardauth-middleware.manifest.metadata.name | ||
namespace = var.namespace | ||
} | ||
] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
output "forward-auth-middleware" { | ||
description = "middleware name for use with forward auth" | ||
value = { | ||
name = kubernetes_manifest.forwardauth-middleware.manifest.metadata.name | ||
} | ||
} | ||
|
||
output "forward-auth-service" { | ||
description = "middleware name for use with forward auth" | ||
value = { | ||
name = kubernetes_service.forwardauth-service.metadata.0.name | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flyby: add helpful comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also select and ignore had to be moved to [tool.ruff.lint]. I was getting a warning saying the old location was deprectaed.