Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore JupyterHub updates from PR-2427 #2465

Merged
merged 1 commit into from
May 16, 2024

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

What does this implement/fix?

Due to an issue with the latest release cycle, the changes made from PR #2427 were rolled back to complete the release; this PR re-introduces these changes.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This merely restores the work originally created by the authors mentioned in the PR, to whom all credit is due.

@viniciusdc viniciusdc requested a review from krassowski May 14, 2024 13:58
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I will follow-up with a set of PR to update it to 4.0.0-0.dev.git.6607.hd1a1130e which uses 5.0.0b2

@krassowski krassowski changed the title Restore updates from PR-2427 Restore JupyterHub updates from PR-2427 May 14, 2024
@krassowski
Copy link
Member

krassowski commented May 14, 2024

@viniciusdc looks good, can we ready to merge it (just because my subsequent PR will otherwise have merge conflicts)?

@krassowski krassowski merged commit fa07566 into develop May 16, 2024
26 checks passed
@krassowski krassowski deleted the restore-jupyterhub-upgrade branch May 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants