Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade instructions for PR 2453 #2466

Merged
merged 12 commits into from
May 23, 2024
Merged

upgrade instructions for PR 2453 #2466

merged 12 commits into from
May 23, 2024

Conversation

Adam-D-Lewis
Copy link
Member

Reference Issues or PRs

This is a companion PR to #2453. B/c we don't yet know for sure the next version of Nebari will be 2024.5.2, I've added this PR to be corrected and merged shortly before the next release of Nebari.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis added this to the 2024.5.2 milestone May 14, 2024
@Adam-D-Lewis Adam-D-Lewis mentioned this pull request May 14, 2024
10 tasks
@Adam-D-Lewis Adam-D-Lewis changed the title change default gcp instances to cost optimized e2 family instances upgrade instructions for PR 2453 May 14, 2024
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adam-D-Lewis I'm leaving a couple suggestions here implementing textwrap.dedent() instead of your custom _wrap function with the aim of making the text more readable.

Feel free to ignore them if you think your approach is better.

src/_nebari/upgrade.py Outdated Show resolved Hide resolved
src/_nebari/upgrade.py Outdated Show resolved Hide resolved
src/_nebari/upgrade.py Outdated Show resolved Hide resolved
src/_nebari/upgrade.py Outdated Show resolved Hide resolved
@Adam-D-Lewis
Copy link
Member Author

@marcelovilla I'm fine with the updates!

@viniciusdc
Copy link
Contributor

@Adam-D-Lewis @marcelovilla any updates on this? can we commit these suggestion and re-test?

@marcelovilla
Copy link
Member

marcelovilla commented May 23, 2024

@viniciusdc I just committed the suggestions. I was hoping to use this PR to include the instructions for upgrading Grafana as well but we can split it in multiple PRs if it makes more sense. Anyway, this should be included in the official release but not necessarily on the RCs, right?

@marcelovilla
Copy link
Member

I'm merging this in order to release a candidate that includes the upgrade step for the GCP default nodes. Once #2472 is merged, I'll open a PR updating the step with relevant information about the actions that need to be taken.

@marcelovilla marcelovilla merged commit 619684d into develop May 23, 2024
26 checks passed
@marcelovilla marcelovilla deleted the gcp_nodes_upgrade_step branch May 23, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants