-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade instructions for PR 2453 #2466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adam-D-Lewis I'm leaving a couple suggestions here implementing textwrap.dedent()
instead of your custom _wrap
function with the aim of making the text more readable.
Feel free to ignore them if you think your approach is better.
@marcelovilla I'm fine with the updates! |
@Adam-D-Lewis @marcelovilla any updates on this? can we commit these suggestion and re-test? |
@viniciusdc I just committed the suggestions. I was hoping to use this PR to include the instructions for upgrading Grafana as well but we can split it in multiple PRs if it makes more sense. Anyway, this should be included in the official release but not necessarily on the RCs, right? |
I'm merging this in order to release a candidate that includes the upgrade step for the GCP default nodes. Once #2472 is merged, I'll open a PR updating the step with relevant information about the actions that need to be taken. |
Reference Issues or PRs
This is a companion PR to #2453. B/c we don't yet know for sure the next version of Nebari will be 2024.5.2, I've added this PR to be corrected and merged shortly before the next release of Nebari.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?