Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm Chart for JupyterHub 5.0.0 final #2484

Merged
merged 1 commit into from
May 28, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 27, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): version update

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

For reference the helm chart - JupyterHub version mapping is available at https://hub.jupyter.org/helm-chart/

@krassowski
Copy link
Member Author

Looking good locally:

image

@krassowski krassowski marked this pull request as ready for review May 27, 2024 10:10
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Whenever it's available, we should switch to a version listed in https://hub.jupyter.org/helm-chart/, right?

@krassowski
Copy link
Member Author

Whenever it's available, we should switch to a version listed in https://hub.jupyter.org/helm-chart/, right?

Yes, we should switch to a tagged version once it is available; I do not expect any changes, but it will be easier to find out to which version it maps because the dev versions are only listed on the docs page for up to a year.

@krassowski krassowski merged commit 3c2d26d into nebari-dev:develop May 28, 2024
9 checks passed
@krassowski krassowski deleted the jhub-5.0.0-finale branch August 29, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants