Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VSCode from jhub_apps default services #2503

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jbouder
Copy link
Contributor

@jbouder jbouder commented Jun 7, 2024

VSCode is now added by default to the new JHub Apps/App Launcher side navigation. This update, in addition to Nebari providing a default list of services for jhub_apps (which includes VSCode), is causing a duplicate entry in the side navigation.

This PR removes VSCode from the default jub_apps configuration as it is not needed anymore and resolves the duplicate entry.

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech merged commit 749a1f1 into nebari-dev:develop Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants