-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda-store permissions v2 + load roles from keycloak #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Outdated
Show resolved
Hide resolved
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Outdated
Show resolved
Hide resolved
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Show resolved
Hide resolved
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Outdated
Show resolved
Hide resolved
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Outdated
Show resolved
Hide resolved
Adam-D-Lewis
reviewed
Jul 1, 2024
...netes_services/template/modules/kubernetes/services/conda-store/config/conda_store_config.py
Outdated
Show resolved
Hide resolved
Adam-D-Lewis
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
- specificy log format via c.CondaStoreServer.log_format - Fix capitalization in KeyCloakCondaStoreRoleScopes - more readable log message for role validation - use internal urls for accessing keycloak
Adam-D-Lewis
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #2433 #2490
Docs: nebari-dev/nebari-docs#480
Rendered link: https://deploy-preview-480--nebari-docs.netlify.app/docs/how-tos/fine-grained-permissions
This achieves the following two things:
This PR basically lets you assign conda-store roles to users/groups from keycloak:
The following role when applied to a group or user will give the users in group /user "viewer" access to namespace "aktech":
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?