Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default roles at initialisation #2546

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Add a default roles at initialisation #2546

merged 13 commits into from
Jul 12, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Jun 27, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2536

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech force-pushed the default-jhub-roles branch from 3b8bfbd to e088662 Compare July 11, 2024 09:57
@aktech aktech force-pushed the default-jhub-roles branch from 3a60d19 to 9091168 Compare July 11, 2024 13:49
@aktech aktech requested a review from krassowski July 11, 2024 14:32
@aktech aktech marked this pull request as ready for review July 11, 2024 14:32
@aktech aktech changed the title Add a default role for app sharing Add a default roles at initialisation Jul 11, 2024
@aktech aktech requested a review from krassowski July 12, 2024 11:01
@krassowski
Copy link
Member

The code looks fine at first glance, but Local Integration Tests job is failing. I know it was flaky last time I did a PR so I restarted it.

@aktech
Copy link
Member Author

aktech commented Jul 12, 2024

Yeah, the playwright test and the jupyterhub ssh tests are a bit flaky. Finally all green.

krassowski
krassowski approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/jupyterhub/main.tf Outdated Show resolved Hide resolved
@aktech @krassowski
groups -> "groups"
5c60c4c 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@aktech aktech merged commit 4f8fc54 into develop Jul 12, 2024
28 checks passed
@aktech aktech deleted the default-jhub-roles branch July 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

@Adam-D-Lewis Adam-D-Lewis Awaiting requested review from Adam-D-Lewis

@marcelovilla marcelovilla Awaiting requested review from marcelovilla

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] - Add a default keycloak role to allow app sharing for convenience
2 participants
@aktech @krassowski