Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a "moved" block to account for refactored terraform code without deleting/recreating NFS disks #2639

Merged
merged 3 commits into from
Aug 27, 2024
Merged

add a "moved" block to account for refactored terraform code without deleting/recreating NFS disks #2639

merged 3 commits into from
Aug 27, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Aug 26, 2024 •
edited
Loading

Reference Issues or PRs

Fixes #2638
Uses moved blocks to account for refactored terraform code.

I've tested on the following deployments.

  • Local
  • GCP
  • Azure

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title add to thing add a move block to account for refactored terraform code without deleting/recreating NFS disks Aug 26, 2024
@Adam-D-Lewis Adam-D-Lewis self-assigned this Aug 26, 2024
@Adam-D-Lewis Adam-D-Lewis added this to the Next Release milestone Aug 26, 2024
@Adam-D-Lewis Adam-D-Lewis requested a review from aktech August 26, 2024 22:36
@Adam-D-Lewis Adam-D-Lewis changed the title add a move block to account for refactored terraform code without deleting/recreating NFS disks add a "moved" block to account for refactored terraform code without deleting/recreating NFS disks Aug 27, 2024
aktech
aktech approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Adam-D-Lewis

@aktech aktech merged commit 3caf45b into develop Aug 27, 2024
28 checks passed
@aktech aktech deleted the move_block branch August 27, 2024 21:35
This was referenced Aug 30, 2024
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech approved these changes

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

@marcelovilla marcelovilla Awaiting requested review from marcelovilla

Assignees

@Adam-D-Lewis Adam-D-Lewis

Labels
None yet
Projects
None yet
Milestone
2024.9.1 Release
Development

Successfully merging this pull request may close these issues.

Latest Rook Ceph PR requires deletion/recreation of NFS drives for all deployments
2 participants
@Adam-D-Lewis @aktech