Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard fix usage report #2671

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

kenafoster
Copy link
Contributor

Reference Issues or PRs

Fixes #2591

What does this implement/fix?

Put a x in the boxes that apply

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [ X ] Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Deploy nebari with this commit - check Grafana Dashboard "Usage Report" and you should see data (note that at least one JuptyerLab user environment must be running to see data)

Any other comments?

@kcpevey kcpevey requested review from dcmcand and removed request for Adam-D-Lewis September 2, 2024 15:17
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Jupyterlab and Dask. Looks good! 🚀

@dcmcand dcmcand merged commit ebc8e1f into nebari-dev:develop Sep 3, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Fix Two Broken Grafana Dashboards
2 participants