Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hub variable for jupyterhub_dashboard #2721

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix hub variable for jupyterhub_dashboard #2721

merged 2 commits into from
Oct 23, 2024

Conversation

kenafoster
Copy link
Contributor

Reference Issues or PRs

Fixes JupyterHub Dashboard issue - #2591

What does this implement/fix?

Put a x in the boxes that apply

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [ X ] Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Deploy Nebari from this branch. Make sure at least one JupyterLab user server is running, then check the Grafana dashboard 'Main > JupyterHub Dashboard'. Several dashboards which were empty prior to this change should now show data.

Any other comments?

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dcmcand dcmcand merged commit a234597 into main Oct 23, 2024
26 of 28 checks passed
@dcmcand dcmcand deleted the jhub-var-update branch October 23, 2024 12:30
@viniciusdc viniciusdc modified the milestone: 2024.9.2 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants