Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run terraform init before running terraform show #2734

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

marcelovilla
Copy link
Member

@marcelovilla marcelovilla commented Sep 23, 2024

Reference Issues or PRs

Closes #2732

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

  1. Install nebari==2024.7.1
  2. Go through the guided init, making sure a GitHub repo is initialized for the Nebari deployment
  3. Deploy Nebari
  4. Install Nebari from this branch running:
pip install git+https://github.com/nebari-dev/nebari.git@run-init-before-show
  1. Upgrade Nebari
  2. Render the files
  3. Make sure the .github/workflows/nebari-ops.yaml file installs Nebari from this branch
  4. Commit and push the changes and let GHA run the re-deployment

Any other comments?

Shout-out to @dcmcand and @viniciusdc for helping me with this solution

@marcelovilla marcelovilla marked this pull request as ready for review September 23, 2024 20:14
@viniciusdc viniciusdc merged commit c28569d into develop Sep 23, 2024
28 checks passed
@viniciusdc viniciusdc deleted the run-init-before-show branch September 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Terraform error when upgrading GCP deployment to latest RC using GHA
2 participants