Use tofu binary instead of terraform one #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/nebari into terraform-to-opentofu
Adam-D-Lewis
reviewed
Nov 6, 2024
@Adam-D-Lewis I did test an upgrade on GCP and everything went smooth. I still think it would be worthwhile to test both an AWS and Azure upgrade |
|
Here's a passing local upgrade test: https://github.com/nebari-dev/nebari/actions/runs/11740475035/job/32707098771 |
dcmcand
approved these changes
Nov 12, 2024
|
I'll be testing a couple more scenarios before merging. @Adam-D-Lewis do you think you can test this on an Azure deployment when you have some time? |
I did a fresh deployment and no problems came up |
|
I deployed 2024.7.1then ran nebari upgrade and deployed and got an error. Here are the logs. Update: It looks like it was something unrelated to this PR which caused the node groups to be deleted and recreated, redeploying seems to work fine. Ahh, I think it's expected, I just didn't see the warning since the warning will only show up in 2024.11.1 upgrade notes, and I only upgraded to 2024.9.2 in this branch. |
|
I've successfully tested this on AWS manually by deploying Nebari 2024.7.1, upgrading to this branch, redeploying and then destroying. |
smokestacklightnin
added a commit
to smokestacklightnin/nebari
that referenced
this pull request
Dec 4, 2024
commit bbbcde3 Merge: ce71236 3ac01b4 Author: Marcelo Villa <mvilla@quansight.com> Date: Thu Nov 28 14:42:36 2024 -0500 Disable `jupyterlab-jhub-apps` extension when jhub-apps is disabled (nebari-dev#2804) commit ce71236 Author: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com> Date: Thu Nov 21 13:53:57 2024 -0300 Add 2024.11.1 release notes and bump version (nebari-dev#2859) commit d272176 Merge: b442200 bbff007 Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Nov 20 08:56:51 2024 -0500 Use tofu binary instead of terraform one (nebari-dev#2773) commit bbff007 Merge: 0ecf6ef b442200 Author: Marcelo Villa <mvilla@quansight.com> Date: Tue Nov 19 08:55:47 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit 3ac01b4 Merge: a0bceea 621ea23 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Mon Nov 18 19:13:53 2024 +0100 Merge branch 'main' into disable-jupyterlab-jhub-apps-extension commit 0ecf6ef Merge: a40cd40 621ea23 Author: Marcelo Villa <mvilla@quansight.com> Date: Thu Nov 14 16:32:07 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit a40cd40 Merge: 8e59c24 e7ff089 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Thu Nov 14 21:35:20 2024 +0100 specify terraform registry for providers not in opentofu registry (nebari-dev#2852) commit e7ff089 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Thu Nov 14 17:56:35 2024 +0100 only update kind commit 6f1b8d6 Merge: b2dd11c 8e59c24 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Wed Nov 13 18:03:11 2024 +0100 Merge branch 'terraform-to-opentofu' into 2857-fix-providers commit 8e59c24 Merge: ff29935 87ed92b Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Nov 13 10:16:32 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit b2dd11c Merge: 415b136 ff29935 Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Nov 13 10:15:25 2024 -0500 Merge branch 'terraform-to-opentofu' into 2857-fix-providers commit 415b136 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Wed Nov 13 13:44:29 2024 +0100 specify terraform registry for providers not in opentofu registry commit ff29935 Merge: aef2796 855aa14 Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Nov 6 13:29:43 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit aef2796 Merge: 06f9043 3429260 Author: Chuck McAndrew <6248903+dcmcand@users.noreply.github.com> Date: Wed Nov 6 16:26:34 2024 +0100 Merge branch 'main' into terraform-to-opentofu commit a0bceea Author: krassowski <5832902+krassowski@users.noreply.github.com> Date: Thu Oct 31 12:56:20 2024 +0000 Fix typo commit b8530d6 Author: krassowski <5832902+krassowski@users.noreply.github.com> Date: Tue Oct 29 13:56:56 2024 +0000 Mount `page_config.json` in top-level so that it applies across potential JupyterLab startup environments also the previous spec was incorrectly pointing to a file (not a dir) commit d1572eb Author: krassowski <5832902+krassowski@users.noreply.github.com> Date: Tue Oct 29 10:43:29 2024 +0000 Disable `jupyterlab-jhub-apps` extension when jhub-apps is disabled (if installed) commit 06f9043 Merge: 8f709da ba0ae82 Author: Marcelo Villa <mvilla@quansight.com> Date: Fri Oct 25 03:28:49 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit 8f709da Author: Marcelo Villa <mvilla@quansight.com> Date: Thu Oct 17 08:03:09 2024 +0200 Fix wrong function reference commit 2b8c347 Merge: 80d67b9 c2ae895 Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Oct 16 23:36:10 2024 +0200 Merge branch 'terraform-to-opentofu' of https://github.com/nebari-dev/nebari into terraform-to-opentofu commit 80d67b9 Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Oct 16 23:36:01 2024 +0200 Rename terraform.py file and terraform_init calls commit c2ae895 Merge: 6a09d4e ccb8b7e Author: Marcelo Villa <mvilla@quansight.com> Date: Wed Oct 16 08:16:50 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit 6a09d4e Merge: d1dfabe 38960ea Author: Marcelo Villa <mvilla@quansight.com> Date: Tue Oct 15 04:54:16 2024 -0500 Merge branch 'main' into terraform-to-opentofu commit d1dfabe Author: Marcelo Villa <mvilla@quansight.com> Date: Tue Oct 15 11:53:49 2024 +0200 Remove terraform open source license test commit 96609c8 Author: Marcelo Villa <mvilla@quansight.com> Date: Mon Oct 14 23:00:05 2024 +0200 Use tofu binary instead of terraform one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #2762
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
I think there are two important things to test with this PR: (1) deploy from scratch using the OpenTofu binary, and (2) upgrade an existing cluster using the OpenTofu binary. To test:
All resources should be correctly deployed and Nebari should be running as usual after.
Any other comments?
This has been successfully tested in the following scenarios:
2024.9.1GCP deployment to 8f709da