Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover develop reference #2792

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Remove leftover develop reference #2792

merged 1 commit into from
Oct 23, 2024

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

See #2770. I missed one reference on a previous PR: #2769

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla marcelovilla requested a review from joneszc October 23, 2024 21:10
@marcelovilla marcelovilla mentioned this pull request Oct 23, 2024
Closed
joneszc
joneszc approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@joneszc joneszc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marcelovilla marcelovilla merged commit 215bbd6 into main Oct 23, 2024
7 checks passed
@marcelovilla marcelovilla deleted the remove-develop-target branch October 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneszc joneszc joneszc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelovilla @joneszc