Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes formatting to restore docs syncing functionality #2809

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

Closes #2805

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Compare the changes against nebari-dev/nebari-docs@1815d21 and validate that all checks ran successfully there.

Any other comments?

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelovilla can you re-run the formatting, just to make sure the changes merged by Adam's PR are in fact applied here as well

@marcelovilla
Copy link
Member Author

@viniciusdc Adam's note about the broken version seems fine and does not need any modification. We'll have to keep an eye on the notes we generate for the hotfix, though

@viniciusdc
Copy link
Contributor

Thanks, @marcelovilla. I was unsure if it had been included when you first opened the PR! thanks again for double checking

@viniciusdc viniciusdc merged commit 88dfe24 into main Oct 30, 2024
4 checks passed
@viniciusdc viniciusdc deleted the fix-release-notes-format branch October 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

RELEASE.md causing syncing issues with documentation site
2 participants