Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unmaintained nix files #2831

Merged
merged 1 commit into from
Nov 6, 2024
Merged

remove unmaintained nix files #2831

merged 1 commit into from
Nov 6, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Nov 6, 2024

Reference Issues or PRs

Nix dev environment is unmaintained and can't be used without some effort to fix the nix files. Since none of the Nebari developers are actively using it, I propose we remove these broken files.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Remove unmaintained Nix dev environment

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis. I've always seen those files lingering around and I guess it's true nobody is actually using them.

@Adam-D-Lewis Adam-D-Lewis merged commit 855aa14 into main Nov 6, 2024
4 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the remove_nix branch November 6, 2024 15:43
@viniciusdc viniciusdc added this to the 2024.12.1 release milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

3 participants